[Mono-bugs] [Bug 77500][Nor] Changed - [PATCH] XmlCustomFormatter / XmlSerializationWriter fixes

[bugzilla-daemon at bugzilla.ximian.com]

Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

Changed by gert.driesen at pandora.be.

http://bugzilla.ximian.com/show_bug.cgi?id=77500

--- shadow/77500	2006-02-08 03:52:53.000000000 -0500
+++ shadow/77500.tmp.8981	2006-02-08 04:08:53.000000000 -0500
@@ -80,6 +80,19 @@
 
 ------- Additional Comments From atsushi at ximian.com  2006-02-08 03:52 -------
 I haven't tried but the patch looks good to handle enums.
 
 I don't think mixing test addition and replacing Assertion->Assert is
 good.
+
+------- Additional Comments From gert.driesen at pandora.be  2006-02-08 04:08 -------
+If you're parsing, for example, a delimited enum string then it 
+makes more sense to say which part is not valid but when you're 
+recreating one from a numerical value its not.
+
+If a bit-field enum which has the following fields 1, 2, 3 (which do 
+not make sense ofcourse) and you pass value 8, then it makes more 
+sense to say that '8' is an invalid value instead of '4', no ?
+
+About mixing test addition and replacing Assertion->Assert: you're 
+right, I should've split this up. But then again, I can hardly 
+submit a bug report for Assertion -> Assert ;-)