[Mono-bugs] [Bug 80411][Nor] Changed - Setting ActiveControl does not raise ArgumentException when it should

[bugzilla-daemon at bugzilla.ximian.com]

Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

Changed by georgegiolfan at yahoo.com.

http://bugzilla.ximian.com/show_bug.cgi?id=80411

--- shadow/80411	2006-12-31 06:35:06.000000000 -0500
+++ shadow/80411.tmp.14871	2006-12-31 08:04:27.000000000 -0500
@@ -42,6 +42,15 @@
 
 ------- Additional Comments From gert.driesen at pandora.be  2006-12-31 06:35 -------
 Toshok reverted your changes since it broke other stuff.
 
 I've committed some unit tests for ContainerControl.ActiveControl in 
 ContainerControlTest.cs and marked them NotWorking.
+
+------- Additional Comments From georgegiolfan at yahoo.com  2006-12-31 08:04 -------
+Here is an idea. Removing !Contains(value) in the first check was 
+correct, but the without this check the ActiveControl of a control 
+could be set to itself, causing infinite recursion later. This 
+happens at least in Control.Select(Control). ArgumentException should 
+be thrown in this case, so the second part of the check for throwing 
+should be removed.
+Please see if the change in Control.Select(bool, bool) is necessary.