[Mono-bugs] [Bug 78185][Nor] Changed - Missing support for scalableAngle in LinearGradientBrush

[bugzilla-daemon at bugzilla.ximian.com]

Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

Changed by sebastien at ximian.com.

http://bugzilla.ximian.com/show_bug.cgi?id=78185

--- shadow/78185	2006-04-26 01:23:58.000000000 -0400
+++ shadow/78185.tmp.9790	2006-04-26 09:16:35.000000000 -0400
@@ -1,23 +1,22 @@
 Bug#: 78185
 Product: Mono: Class Libraries
 Version: 1.1
-OS: 
+OS: unknown
 OS Details: 
 Status: NEW   
 Resolution: 
-Severity: 
+Severity: Unknown
 Priority: Normal
 Component: libgdiplus
 AssignedTo: peter at novonyx.com                            
 ReportedBy: sebastien at ximian.com               
 QAContact: mono-bugs at ximian.com
 TargetMilestone: ---
 URL: 
-Cc: 
-Summary: Incorrect features in LinearGradientBrush
+Summary: Missing support for scalableAngle in LinearGradientBrush
 
 Description of Problem:
 
 LinearGradientBrush doesn't propertly supports the following features:
 * FlipX, FlipY and FlipXY modes
 * Scalable angles
@@ -30,6 +29,43 @@
 
 
 ------- Additional Comments From billholmes54 at gmail.com  2006-04-26 01:23 -------
 Created an attachment (id=16836)
 proposed patch
 
+
+------- Additional Comments From billholmes54 at gmail.com  2006-04-26 01:47 -------
+As far as I can tell from the samples I have looked at WrapModeTile
+and WrapModeTileFlipY are the same.  Also WrapModeTileFlipX and
+WrapModeTileFlipXY are the same as well.  If you consider that a
+linear gradient brush does only vary its pattern in the X direction
+this makes sense.  Flipping the points about the X axis would change
+nothing visually.
+
+Although the change looks big it is more code cleanup then anything. 
+The real change is to call cairo_pattern_set_extend with the
+CAIRO_EXTEND_REPEAT or CAIRO_EXTEND_REFLECT flag depending on the
+WrapMode flag.
+
+I also commented out some code in GdipGetLineTransform that was
+checking if the number of colors were >= to 2 ???  This was causing a
+problem with the attached test case.  As you can see I also thought I
+should add my contact info and the bug # for future reference.  
+
+
+------- Additional Comments From sebastien at ximian.com  2006-04-26 09:16 -------
+Impressive sample (and fix). I had the same results yesterday for
+WrapModeTile / WrapModeTileFlipY and WrapModeTileFlipX /
+WrapModeTileFlipXY (and doubted my own sample). This may be because
+the same enum may be shared with other classes (where it make sense).
+
+You don't have to include notes inside the source code. You can do
+this in the ChangeLog. Afterward anyone can use "svn blame" (or look
+at the web interface over svn) to see who (and when was) made a
+modification (and read the related information in the ChangeLog). Also
+the later removal can be easily be validated by adding a new unit test
+inside System.Drawing.
+
+I applied the patch into SVN (r59926) and I'm renaming the bug to
+reflect the last missing feature.
+
+