[Mono-bugs] [Bug 77792][Nor] Changed - Poor performace of Int32.ToString () and other primitive types

[bugzilla-daemon at bugzilla.ximian.com]

Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

Changed by marek.safar at seznam.cz.

http://bugzilla.ximian.com/show_bug.cgi?id=77792

--- shadow/77792	2006-04-05 00:56:18.000000000 -0400
+++ shadow/77792.tmp.3387	2006-04-05 04:18:59.000000000 -0400
@@ -195,6 +195,24 @@
 ------- Additional Comments From atsushi at ximian.com  2006-04-05 00:56 -------
 The patch makes performance much better than before :-)  So, if no
 objection from others, let's commit the patch.
 
 My guess is that this is not really a major problem since none of them
 posted any thoughts for the patch.
+
+------- Additional Comments From marek.safar at seznam.cz  2006-04-05 04:18 -------
+Yep, the performance improvement is sweet I am just not sure about
+all this copy&paste
+
+-			return NumberToString (format, new NumberStore (value), nfi);
++			char specifier;
++			int precision;
++			bool custom;
++			ParseBasicFormat (format, out specifier, out precision, out custom);
++			if (specifier == 'x' || specifier == 'X')
++				return FormatHexadecimal (value, true, 1, precision, specifier ==
+'X');
++			return NumberToString (format, new NumberStore (value), nfi,
+specifier, precision, custom);
+
+
+Is is possible to avoid it ?