[Mono-bugs] [Bug 74952][Nor] Changed - Rapid RSA construct-> random number generator -> NullReference

[bugzilla-daemon at bugzilla.ximian.com]

Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

Changed by vargaz at gmail.com.

http://bugzilla.ximian.com/show_bug.cgi?id=74952

--- shadow/74952	2005-05-17 23:44:37.000000000 -0400
+++ shadow/74952.tmp.25644	2005-05-18 08:46:30.000000000 -0400
@@ -1,12 +1,12 @@
 Bug#: 74952
 Product: Mono: Class Libraries
 Version: unspecified
 OS: unknown
 OS Details: AMD64 - Gentoo
-Status: NEEDINFO   
+Status: REOPENED   
 Resolution: 
 Severity: Unknown
 Priority: Normal
 Component: CORLIB
 AssignedTo: mono-bugs at ximian.com                            
 ReportedBy: harningt at gmail.com               
@@ -132,6 +132,16 @@
 ------- Additional Comments From harningt at gmail.com  2005-05-17 23:44 -------
 After a few tries, it managed to run into the same error again.
 I upgraded to SVN HEAD: 44640
 
 I decided to take a look at the code and everything in Mono looks ok.
  Wonder what it could be :-/
+
+------- Additional Comments From vargaz at gmail.com  2005-05-18 08:46 -------
+BTW, the code uses the double-check locking pattern, which is not
+neccessary thread-safe:
+
+http://www.skeet.org.uk/csharp/singleton.html
+
+Better to do the check inside the lock, especially in non-perf critical
+code such as this.
+