[Mono-bugs] [Bug 74830][Nor] Changed - abort in debug mode

[bugzilla-daemon@bugzilla.ximian.com]

Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

Changed by martin@ximian.com.

http://bugzilla.ximian.com/show_bug.cgi?id=74830

--- shadow/74830	2005-05-09 10:40:53.000000000 -0400
+++ shadow/74830.tmp.26954	2005-05-11 14:49:10.000000000 -0400
@@ -1651,6 +1651,16 @@
 ------- Additional Comments From lupus@ximian.com  2005-05-09 10:40 -------
 --debug is only marginally useful, since it just provides file:line
 information and it should not be used by default until all the related
 code is tested and fixed.
 Anyway, I committed to svn the change I suggested above since I guess
 the zmd folks wont test it:-(
+
+------- Additional Comments From martin@ximian.com  2005-05-11 14:49 -------
+mono_debugger_lock()/mono_debugger_unlock() shouldn't do anything
+unless you're running in the debugger.
+
+However, what I see from the stack trace is the g_assert() in it - we
+basically don't need that at all, so I turned it into a warning.
+
+I also fixed another issue in mono_debug_add_method() where we were
+returning on error without releasing the lock in some cases.