[Mono-bugs] [Bug 74868][Nor] Changed - [PATCH] Color.GetBrightness and GetSaturation return wrong values
bugzilla-daemon@bugzilla.ximian.com
bugzilla-daemon@bugzilla.ximian.com
Mon, 9 May 2005 18:51:33 -0400 (EDT)
Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.
Changed by peter@novonyx.com.
http://bugzilla.ximian.com/show_bug.cgi?id=74868
--- shadow/74868 2005-05-09 18:27:29.000000000 -0400
+++ shadow/74868.tmp.9265 2005-05-09 18:51:33.000000000 -0400
@@ -59,6 +59,12 @@
color.patch (version with nested class)
------- Additional Comments From jackson@ximian.com 2005-05-09 18:27 -------
In my opinion we shouldn't be caching the hsb. Assigning to peter as
it is up to him.
+
+------- Additional Comments From peter@novonyx.com 2005-05-09 18:51 -------
+Agreed. I'm going by my original comment that we should move the math
+into each function like the code was before. I recall a discussion
+several months back about whether or not to cache the hsb and the
+outcome was that we didn't want to keep it around.