[Mono-bugs] [Bug 74868][Nor] Changed - [PATCH] Color.GetBrightness and GetSaturation return wrong values

bugzilla-daemon@bugzilla.ximian.com bugzilla-daemon@bugzilla.ximian.com
Mon, 9 May 2005 16:52:37 -0400 (EDT)


Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

Changed by peter@novonyx.com.

http://bugzilla.ximian.com/show_bug.cgi?id=74868

--- shadow/74868	2005-05-09 16:47:54.000000000 -0400
+++ shadow/74868.tmp.8285	2005-05-09 16:52:37.000000000 -0400
@@ -34,6 +34,13 @@
 Created an attachment (id=15094)
 Patch and NUnit test case
 
 
 ------- Additional Comments From juraj@hotfeet.ch  2005-05-08 09:30 -------
 May I commit?
+
+------- Additional Comments From peter@novonyx.com  2005-05-09 16:52 -------
+Thanks for the patch. Works great, but I don't like the separate 
+class (and file) that's been introduced for this. If you insist on 
+the separate class, could you please move it into the Color.cs file 
+as a subclass, or, better, move the math into each function like the 
+code you are replacing had it originally?