[Mono-bugs] [Bug 73356][Blo] New - mod_mono is not deleting the socket file when the default socket name is being used.

bugzilla-daemon@bugzilla.ximian.com bugzilla-daemon@bugzilla.ximian.com
Fri, 4 Mar 2005 13:57:26 -0500 (EST)


Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

Changed by rlyon@novell.com.

http://bugzilla.ximian.com/show_bug.cgi?id=73356

--- shadow/73356	2005-03-04 13:57:26.000000000 -0500
+++ shadow/73356.tmp.12834	2005-03-04 13:57:26.000000000 -0500
@@ -0,0 +1,45 @@
+Bug#: 73356
+Product: Mono: Tools
+Version: 1.1
+OS: 
+OS Details: 
+Status: NEW   
+Resolution: 
+Severity: 
+Priority: Blocker
+Component: mod_mono
+AssignedTo: gonzalo@ximian.com                            
+ReportedBy: rlyon@novell.com               
+QAContact: mono-bugs@ximian.com
+TargetMilestone: ---
+URL: 
+Cc: 
+Summary: mod_mono is not deleting the socket file when the default socket name is being used.
+
+mod_mono is not deleting the socket file when the default socket name is 
+being used.
+
+Here is a possible fix:
+
+Index: src/mod_mono.c
+===================================================================
+--- src/mod_mono.c	(revision 41376)
++++ src/mod_mono.c	(working copy)
+@@ -1216,8 +1215,15 @@
+ 			write_data (sock, termstr, 1);
+ 		}
+ 
+-		if (xsp->listen_port == NULL && xsp->filename != NULL)
+-			remove (xsp->filename); /* Don't bother checking 
+error */
++		if (xsp->listen_port == NULL)
++        {
++            char *fn = xsp->filename;
++
++            if (fn == NULL)
++                fn = get_default_socket_name (pconf, xsp->alias, 
+SOCKET_FILE);
++
++			remove (fn); /* Don't bother checking error */
++        }
+ 	}