[Mono-bugs] [Bug 73185][Nor] Changed - Server-side sockets accumulate while waiting for gc in mod-mono-server

bugzilla-daemon@bugzilla.ximian.com bugzilla-daemon@bugzilla.ximian.com
Wed, 2 Mar 2005 01:14:19 -0500 (EST)

Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

Changed by gonzalo@ximian.com.


--- shadow/73185	2005-03-01 21:14:55.000000000 -0500
+++ shadow/73185.tmp.26826	2005-03-02 01:14:19.000000000 -0500
@@ -1,13 +1,13 @@
 Bug#: 73185
 Product: Mono: Class Libraries
 Version: 1.1
 OS Details: 
-Status: NEW   
+Status: RESOLVED   
+Resolution: FIXED
 Severity: Unknown
 Priority: Normal
 Component: Sys.Web
 AssignedTo: gonzalo@ximian.com                            
 ReportedBy: mlasky@novell.com               
 QAContact: mono-bugs@ximian.com
@@ -49,6 +49,27 @@
 Additional Information:
 ------- Additional Comments From mlasky@novell.com  2005-03-01 19:33 -------
 Created an attachment (id=14479)
 Patch file containing changes
+------- Additional Comments From gonzalo@ximian.com  2005-03-02 01:14 -------
+The patch is not right because it might happen that ProcessRequest is
+not synchronous if the httpruntime queue is used and that finally
+clause will close the stream before the request is processed.
+Thanks to your patch, I saw the lack of a Stream.Close call when
+Decline or NotFound. I fixed this in SVN.
+I also added a Stream.Close to the Close method of ModMonoWorker, and
+this one is the culprit of the problem.
+I was able to reproduce the problem with simple requests for NotFound,
+Decline and the general case (lots of unix sockets opened to
+mod_mono_server_dummy, 'lsof -U') and after the fix I just commited to
+SVN seems to be closing the socket properly.
+Let me know if you still see something wrong with opened sockets.