[Mono-bugs] [Bug 75018][Wis] Changed - [PATCH] Report 'file' is a binary file instead of a source code file

bugzilla-daemon at bugzilla.ximian.com bugzilla-daemon at bugzilla.ximian.com
Tue Jun 14 00:26:55 EDT 2005

Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

Changed by bmaurer at users.sf.net.


--- shadow/75018	2005-06-14 00:24:54.000000000 -0400
+++ shadow/75018.tmp.29005	2005-06-14 00:26:55.000000000 -0400
@@ -76,6 +76,16 @@
 We could basically detect the zero in the tokenizer
 ------- Additional Comments From bmaurer at users.sf.net  2005-06-14 00:24 -------
 That assumes that by the time the \0 was noticed, the compiler hadn't
 already errored out in a strage way.
+------- Additional Comments From bmaurer at users.sf.net  2005-06-14 00:26 -------
+btw, if you are worried about performance, this does *not* cause an
+extra syscall. 4kb is less than the default buffer size for
+filestream, and thus 8 kb of data will be read into an array.
+Position=0 won't discard the contents of the array.
+Given the extremely high chances that a binary file will be caught by
+this patch, I don't think it worth arguing that we are being more
+precise the other way.

More information about the mono-bugs mailing list