[Mono-bugs] [Bug 75123][Nor] Changed - [PATCH] GetChanges() throws NoNullAllowedException

[bugzilla-daemon at bugzilla.ximian.com]

Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

Changed by george.barbarosie at gmail.com.

http://bugzilla.ximian.com/show_bug.cgi?id=75123

--- shadow/75123	2005-06-05 03:41:24.000000000 -0400
+++ shadow/75123.tmp.18132	2005-06-05 05:40:37.000000000 -0400
@@ -141,6 +141,14 @@
 
 
 ------- Additional Comments From atsushi at ximian.com  2005-06-05 03:41 -------
 Suresh: can you please review the patch? This bug is reproducible w/o
 GetXml() and am not so sure how today's
 DataRowCollection.AddInternal() works.
+
+------- Additional Comments From george.barbarosie at gmail.com  2005-06-05 05:40 -------
+Atsushi, DataRowCollection.AddInternal() is called by
+DataRowCollection.Add() after a few checks (row isn't null, row
+belongs to this table, row is detached) and a conditioned call to
+ValidateDataRowInternal(). DataRowCollection.Add() also calls
+row.BeginEdit() before ValidateDataRowInternal(), but I can't
+understand why would that be needed or useful.