[Mono-bugs] [Bug 75633][Nor] New - [FIX] HttpContext + CustomErrors

[bugzilla-daemon at bugzilla.ximian.com]

Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

Changed by mmorano at mikeandwan.us.

http://bugzilla.ximian.com/show_bug.cgi?id=75633

--- shadow/75633	2005-07-25 19:38:46.000000000 -0400
+++ shadow/75633.tmp.1707	2005-07-25 19:38:46.000000000 -0400
@@ -0,0 +1,69 @@
+Bug#: 75633
+Product: Mono: Class Libraries
+Version: 1.1
+OS: 
+OS Details: 
+Status: NEW   
+Resolution: 
+Severity: 
+Priority: Normal
+Component: Sys.Web
+AssignedTo: mono-bugs at ximian.com                            
+ReportedBy: mmorano at mikeandwan.us               
+QAContact: mono-bugs at ximian.com
+TargetMilestone: ---
+URL: 
+Cc: 
+Summary: [FIX] HttpContext + CustomErrors
+
+Description of Problem:
+
+Posted this to mono-devel-list, adding here for tracking.
+
+When using RemoteOnly for the custom error mode in an ASP.Net site, the
+current behavior is backwards (local request would get the default error
+page, and remote requests would get the stack trace). 
+
+
+Steps to reproduce the problem:
+1. Create any aspx page with unhandled exception
+2. In web.config, specify that you want to use a default error page, and
+that it should be configured for "RemoteOnly"
+3. Access the page in a browser that raises the unhandled exception
+
+
+Actual Results:
+
+When viewing locally, you get the default error page defined in the
+web.config.  When viewing remotely, you see the stack trace page.
+
+Expected Results:
+
+The opposite (local viewing should produce stack trace)
+
+
+How often does this happen? 
+
+always
+
+
+Additional Information:
+
+
+Here is the fix that updates the check (System.Web.HttpContext.cs):
+
+Index: HttpContext.cs
+===================================================================
+--- HttpContext.cs      (revision 47587)
++++ HttpContext.cs      (working copy)
+@@ -211,7 +211,7 @@
+                                        return true;
+
+                                return (mode ==
+CustomErrorMode.RemoteOnly &&
+-                                       _oRequest.ServerVariables
+["LOCAL_ADDR"] == _oRequest.UserHostAddress);
++                                       _oRequest.ServerVariables
+["LOCAL_ADDR"] != _oRequest.UserHostAddress);
+                        }
+                }