[Mono-bugs] [Bug 74872][Nor] Changed - [PATCH] System.Uri construction from pre-escaped strings inconsistent

[bugzilla-daemon at bugzilla.ximian.com]

Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

Changed by atsushi at ximian.com.

http://bugzilla.ximian.com/show_bug.cgi?id=74872

--- shadow/74872	2005-07-01 13:56:24.000000000 -0400
+++ shadow/74872.tmp.21167	2005-07-01 14:52:47.000000000 -0400
@@ -11,13 +11,13 @@
 AssignedTo: mono-bugs at ximian.com                            
 ReportedBy: dsd at gentoo.org               
 QAContact: mono-bugs at ximian.com
 TargetMilestone: ---
 URL: 
 Cc: 
-Summary: System.Uri construction from pre-escaped strings inconsistent
+Summary: [PATCH] System.Uri construction from pre-escaped strings inconsistent
 
 Using Mono 1.1.7, constructing a Uri involving the escaped forms of some
 non-ASCII characters seems odd. As you can see from the test case, it seems
 to work fine with "isolated" non-ASCII characters, but not when two are
 together.
 
@@ -105,6 +105,16 @@
 sometimes we might have to return two characters. Are you suggesting
 that we return the first character in the return value, and the second
 through a ref/out parameter?
 
 Another option is to return a char[] array, but I'm not sure how that
 rates in terms of efficiency against strings.
+
+------- Additional Comments From atsushi at ximian.com  2005-07-01 14:52 -------
+Yes, that's exactly what I had in mind. Am attaching further patch
+that includes the change I suggested.
+
+For char[] idea, it will anyways create another object that is not
+good for performance (it would be OK when it happens only for
+surrogate pairs, but it's not difficult just to return the second
+character in additional "out" parameter).
+