[Mono-bugs] [Bug 60638][Wis] Changed - missing warning comparing string with object

bugzilla-daemon@bugzilla.ximian.com bugzilla-daemon@bugzilla.ximian.com
Sun, 13 Feb 2005 06:27:21 -0500 (EST)

Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

Changed by duncan@ximian.com.


--- shadow/60638	2005-02-13 06:22:49.000000000 -0500
+++ shadow/60638.tmp.28045	2005-02-13 06:27:21.000000000 -0500
@@ -36,6 +36,19 @@
 ------- Additional Comments From duncan@ximian.com  2005-02-13 06:22 -------
 Created an attachment (id=14202)
 Here's a possible fix
+------- Additional Comments From duncan@ximian.com  2005-02-13 06:27 -------
+The original code has this part 
+if (l.IsSubclassOf (r) || r.IsSubclassOf (l))
+        return this;
+I'm not sure this is correct, and because of System.Object is involved
+in the test case above, I had to do my checks before this check anyway
+to avoid returning too early.
+In the end, I inserted my own checks and kept it stuck it back after
+my bits.