[Mono-bugs] [Bug 72149][Wis] Changed - ilasm croaks on duplicate symbols in .locals init (patch included)

bugzilla-daemon@bugzilla.ximian.com bugzilla-daemon@bugzilla.ximian.com
Thu, 3 Feb 2005 17:42:09 -0500 (EST)

Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

Changed by peter@emailross.com.


--- shadow/72149	2005-02-03 14:58:51.000000000 -0500
+++ shadow/72149.tmp.21641	2005-02-03 17:42:08.000000000 -0500
@@ -87,6 +87,23 @@
 ------- Additional Comments From monobugs@taggedtype.net  2005-02-03 14:58 -------
 Hi jackson,
 Apologize for the duplication. Unfortunately, if the patch is applied,
 it will likely break duplicate locals with different scope. Perhaps a
 scope needs to be attached to locals?
+------- Additional Comments From peter@emailross.com  2005-02-03 17:42 -------
+I disagree that this is a duplicate of 61666.
+In 61666 you have two distinct blocks with two locals with the same
+name and type.  Here you have a local declared twice in one block.
+I think the patch in this would fix 61666 because the duplicate named
+locals have the same type.  However if they were of different types,
+the code wouldn't be updated to the new type.
+However I think that just deleting the local and then readding the new
+one would be sufficient, as then the new type would be recorded.  For
+this to work though we need to process each block completely before
+moving to the next block.