[Mono-bugs] [Bug 74673][Wis] Changed - [PATCH] New UnixListener and UnixClient classes

bugzilla-daemon@bugzilla.ximian.com bugzilla-daemon@bugzilla.ximian.com
Thu, 21 Apr 2005 17:50:08 -0400 (EDT)

Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

Changed by gonzalo@ximian.com.


--- shadow/74673	2005-04-21 13:15:33.000000000 -0400
+++ shadow/74673.tmp.25634	2005-04-21 17:50:08.000000000 -0400
@@ -1,13 +1,13 @@
 Bug#: 74673
 Product: Mono: Class Libraries
 Version: 1.1
 OS: unknown
 OS Details: 
-Status: NEW   
+Status: RESOLVED   
+Resolution: FIXED
 Severity: Unknown
 Priority: Wishlist
 Component: Mono.POSIX
 AssignedTo: mono-bugs@ximian.com                            
 ReportedBy: joeshaw@novell.com               
 QAContact: mono-bugs@ximian.com
@@ -122,6 +122,46 @@
 	  Connect(), and if it works, fail with an
 	  InvalidOperationException.  The library shouldn't
 	  delete files unless explicitly told to.
 	- Provide a Start() overload to accept the backlog size
 	  (solving the comment in Stop());
+------- Additional Comments From gonzalo@ximian.com  2005-04-21 17:50 -------
+Non-commented requests are in.
+	- The class has no functional virtual methods.  It should 
+	  be `sealed', unless there's a good use case to permit 
+	  derivation.
+A derived class might want to access the Socket directly (Client
+	- Dispose(bool) should set `disposed = true` at the end.
+	  (Think exception safety.)
+Assuming that, as most classes, calling several methods from different
+threads is not safe, fine.
+	- I dislike "brace hugging"; e.g. "else" and "finally" 
+	  should start a new line
+See mcs/CodingStyle ;-)
+	- Should be `sealed', unless there's a good use case for
+	  derivation in the absence of virtual method
+Same case as before.
+	- Consider renaming AcceptUnixClient to
+	  CreateUnixClient, and renaming AcceptSocket to Accept.
+This is to follow the same method naming as TcpListener has.
+	- Stop() never clears `server', nor does it set
+	  "active=false".  Can Stop() be called multiple times?
+I made it so that Stop is a synonym for Dispoes (true).