[Mono-bugs] [Bug 62984][Maj] Changed - [PATCH] CustomAttributeBuilder bug

bugzilla-daemon@bugzilla.ximian.com bugzilla-daemon@bugzilla.ximian.com
Fri, 17 Sep 2004 19:39:37 -0400 (EDT)


Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

Changed by grompf@sublimeintervention.com.

http://bugzilla.ximian.com/show_bug.cgi?id=62984

--- shadow/62984	2004-08-12 19:17:07.000000000 -0400
+++ shadow/62984.tmp.8694	2004-09-17 19:39:37.000000000 -0400
@@ -1,23 +1,23 @@
 Bug#: 62984
 Product: Mono: Class Libraries
 Version: unspecified
-OS: 
+OS: unknown
 OS Details: 
 Status: NEW   
 Resolution: 
-Severity: 
+Severity: Unknown
 Priority: Major
 Component: CORLIB
 AssignedTo: mono-bugs@ximian.com                            
 ReportedBy: marek.safar@seznam.cz               
 QAContact: mono-bugs@ximian.com
 TargetMilestone: ---
 URL: 
 Cc: 
-Summary: CustomAttributeBuilder bug
+Summary: [PATCH] CustomAttributeBuilder bug
 
 This code crashes with System.NullReferenceException and should be runable
 without problem.
 
 Major because it blocks one of my mcs patches.
 
@@ -39,6 +39,14 @@
         ConstructorInfo classCtorInfo = typeof(My).GetConstructor(ctorParams);
         
         CustomAttributeBuilder methodCABuilder = new CustomAttributeBuilder
 (classCtorInfo, new object [] { TypeCode.Double } );        
     }
 }
+
+------- Additional Comments From grompf@sublimeintervention.com  2004-09-17 19:39 -------
+The crux of this bug is that the cattr blob builder was trying to get a class from the 
+basetype which had data of 0x0; this is incorrect behaviour (as far as I understand from 
+marek on irc) it should keep the type boxed; the attached patch brings this behaviour into 
+sync with what marek explained should happen and succeeds in an additional test case 
+from marek (also attached)
+