[Mono-bugs] [Bug 59537][Nor] Changed - improve NameTable performance

[bugzilla-daemon@bugzilla.ximian.com]

Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

Changed by atsushi@ximian.com.

http://bugzilla.ximian.com/show_bug.cgi?id=59537

--- shadow/59537	2004-09-16 02:36:11.000000000 -0400
+++ shadow/59537.tmp.29472	2004-09-16 03:00:23.000000000 -0400
@@ -521,6 +521,43 @@
 In general less space equals more speed on modern processors, where a
 level 2 cache miss can result in 1000 instruction cycles being lost.
 
 ------- Additional Comments From mono@bitfurnace.com  2004-09-16 02:36 -------
 Could someone point me in the right direction for some documents on
 setting up a build and test environment for mono under vs.net 2003. 
+
+------- Additional Comments From atsushi@ximian.com  2004-09-16 03:00 -------
+I could fix your code and now it looks fine.
+
+44c44
+< 				if ((buckets[p].hash == hash) && StrEquals(buckets[p].str, key,
+start))
+---
+> 				if ((buckets[p].hash == hash) && StrEquals(buckets[p].str, key,
+start, len))
+81c81
+< 		private static bool StrEquals(string str, char[] str2, int start)
+---
+> 		private static bool StrEquals(string str, char[] str2, int start,
+int len)
+83,84c83,85
+< 			int len = str.Length;
+< 			if (len != str2.Length - start) return false;
+---
+> 			if (len != str.Length) return false;
+> //			int len = str.Length;
+> //			if (len != str2.Length - start) return false;
+
+Well, there are System.XML.sln, Mono.System.XML.csproj in
+mcs/class/System.XML and MonoMicro.Test.csproj in
+mcs/class/System.XML/Test, but they are old and update is required.
+
+(I think System.XML.sln contains both of the projects above.)
+
+You will have to install NUnit. NUnitAddin would be very helpful for
+running NUnit tests on top of VS.NET.
+http://weblogs.asp.net/NUnitAddin/
+
+Sorry but I cannot provide more information on that matter. Currently
+I have no VS.NET 2003 installation.
+
+Will post a followup on performance issue.