[Mono-bugs] [Bug 67264][Maj] Changed - [PATCH] string.ctor with encoding obj
Tue, 5 Oct 2004 05:27:51 -0400 (EDT)
X-Bugzilla-Product: Mono: Runtime
Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.
Changed by email@example.com.
--- shadow/67264 2004-10-03 10:36:41.000000000 -0400
+++ shadow/67264.tmp.12972 2004-10-05 05:27:50.000000000 -0400
@@ -153,6 +153,15 @@
Would someone be so kind as to approve?
------- Additional Comments From firstname.lastname@example.org 2004-10-03 10:36 -------
Approved, but the actual icall should be removed from string-icalls.c
and icall.c too.
+------- Additional Comments From email@example.com 2004-10-05 05:27 -------
+The patch is incorrect: if it has been tested at all it may have
+worked by luck, because the return value from enc.GetString() happened
+to be left in %eax.
+String ctors can't be implemented that way, because they are
+Michael: you should use the Encoding API directly to work around the
+issue until we fix it: it's going to be faster for your test case anyway.