[Mono-bugs] [Bug 69142][Nor] Changed - [PPC] mini rcheck has failures.

bugzilla-daemon@bugzilla.ximian.com bugzilla-daemon@bugzilla.ximian.com
Fri, 12 Nov 2004 11:30:24 -0500 (EST)

Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

Changed by lupus@ximian.com.


--- shadow/69142	2004-11-11 17:00:50.000000000 -0500
+++ shadow/69142.tmp.5633	2004-11-12 11:30:24.000000000 -0500
@@ -76,6 +76,22 @@
 Overall results: tests: 4446, failed: 26, opt combinations: 13 (pass: 99.42%)
 If its ok I'll commit with changelog summaries of the changes
+------- Additional Comments From lupus@ximian.com  2004-11-12 11:30 -------
+The conditional branch instructions should use the values defined
+in ppc-codegen.h (PPC_BR_*) instead of magic values and references to
+There is no need for the "& 0xffff" here:
+ppc_cmpi (code, 0, 0, ins->sreg1, (0 & 0xffff));
+Branch addresses and targets should have
+meaningful names, not br/label.
+The alternate exception thrown by div/rem should be
+ArithmetricException, not OverflowException.
+Emitting the exception should be done with
+EMIT_COND_SYSTEM_EXCEPTION_FLAGS, so the instruction sequence is
+shorter and you should either use the likely flag or rearrange the
+sequence so that the default case of no exception is straight code
+or we get a pipeline flush every time.