[Mono-bugs] [Bug 69020][Nor] Changed - 'make bootstrap' sometimes fails after 'Could not load class from token ...' warnings and an assertion in 'mono_class_setup_parent'

bugzilla-daemon@bugzilla.ximian.com bugzilla-daemon@bugzilla.ximian.com
Wed, 3 Nov 2004 01:53:58 -0500 (EST)


Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

Changed by rharinath@novell.com.

http://bugzilla.ximian.com/show_bug.cgi?id=69020

--- shadow/69020	2004-11-02 10:42:32.000000000 -0500
+++ shadow/69020.tmp.4369	2004-11-03 01:53:58.000000000 -0500
@@ -88,6 +88,23 @@
 
 
 ------- Additional Comments From vargaz@gmail.com  2004-11-02 10:42 -------
 I'm not sure this is the correct fix. Some applications like ikvm
 depend on being able to "load" dynamic assemblies. They also depend on
 the AssemblyLoaded event being fired.
+
+------- Additional Comments From rharinath@novell.com  2004-11-03 01:53 -------
+Oops.  The patch is missing a couple of parens :-)  I meant:
+
+  if (!(assembly->image->dynamic && ((MonoDynamicImage *)
+assembly->image)->initial_image))
+		add_assemblies_to_domain (domain, assembly);
+
+So, it'll still
+
+  * add non-'initial_image' dynamic assemblies to the domain
+  * always fire off AppDomain.AssemblyLoaded, even for 'initial_image'
+dynamic assemblies
+
+I'm not sure about the semantics of 'initial_image'.  So, I may be
+misusing it above.
+