[Mono-bugs] [Bug 54467][Wis] Changed - Incorrect values when subtracting doubles

bugzilla-daemon@bugzilla.ximian.com bugzilla-daemon@bugzilla.ximian.com
Mon, 24 May 2004 09:19:01 -0400 (EDT)

Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

Changed by lupus@ximian.com.


--- shadow/54467	2004-05-20 05:08:28.000000000 -0400
+++ shadow/54467.tmp.5054	2004-05-24 09:19:01.000000000 -0400
@@ -144,6 +144,16 @@
 Comments appreciated...
 By the way, the "test_0_sqrt_precision_and_spill" test still
 fails, but this is not exactly related to this bug... I am
 still investigating it.
+------- Additional Comments From lupus@ximian.com  2004-05-24 09:19 -------
+fldz-fadd is safe, since we never allocate all the slots in the fp
+stack. If it was an issue it's likely much better to use a fadd with a
+memory reference to a 0.0 value instead of building it on the stack,
+which is slow and requires more code.
+There is no need to split the add of 0: it buys us nothing that I can
+see. Please put the additional tests in a file different from
+basic-float.cs: the tests there should test very basic functionality
+that doesn't require method calls etc.