[Mono-bugs] [Bug 58027][Wis] Changed - Get rid of synch block in MonoObject

bugzilla-daemon@bugzilla.ximian.com bugzilla-daemon@bugzilla.ximian.com
Wed, 5 May 2004 10:43:50 -0400 (EDT)

Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

Changed by lupus@ximian.com.


--- shadow/58027	2004-05-04 23:27:54.000000000 -0400
+++ shadow/58027.tmp.21423	2004-05-05 10:43:50.000000000 -0400
@@ -36,6 +36,18 @@
   annotated with a custom attribute, like Mono.SynchronizationAttribute.
 ------- Additional Comments From bmaurer@users.sf.net  2004-05-04 23:27 -------
 Before, I tried doing this by solution (1). One major problem was that
 alot of code depends on the offset of the field after the sync block
 to be 0 mod 8.
+------- Additional Comments From lupus@ximian.com  2004-05-05 10:43 -------
+Solution 1 is not applicable, IMHO. Our lock/unlock is already three
+times slower than it needs to be and we need to speed it up, not slow
+it down (especially once we audit the assemblies for thread safeness
+and we'll need to perform more locks than now).
+Doing solution 2 would probably not be too hard since, unlike what ben
+claims, there are just one or two places with the alignment
+assumption, but it basically assumes we'll have a slow lock
+implementation like now where we could add the special case code:
+adding it to the inlined lock/unlock code would be a significant