[Mono-bugs] [Bug 54927][Wis] Changed - ArrayList::IndexOf does .Equals on the wrong object

bugzilla-daemon@bugzilla.ximian.com bugzilla-daemon@bugzilla.ximian.com
Mon, 29 Mar 2004 12:02:53 -0500 (EST)


Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

Changed by lluis@ximian.com.

http://bugzilla.ximian.com/show_bug.cgi?id=54927

--- shadow/54927	2004-02-27 08:05:12.000000000 -0500
+++ shadow/54927.tmp.26263	2004-03-29 12:02:53.000000000 -0500
@@ -1,14 +1,14 @@
 Bug#: 54927
-Product: Mono/Class Libraries
+Product: Mono: Class Libraries
 Version: unspecified
-OS: 
+OS: unknown
 OS Details: 
-Status: NEW   
-Resolution: 
-Severity: 
+Status: RESOLVED   
+Resolution: NOTABUG
+Severity: Unknown
 Priority: Wishlist
 Component: CORLIB
 AssignedTo: mono-bugs@ximian.com                            
 ReportedBy: bmaurer@users.sf.net               
 QAContact: mono-bugs@ximian.com
 TargetMilestone: ---
@@ -120,6 +120,22 @@
 
 I fixed these string methods easily enough - I just did my own loop, 
 rather 
 then delegate to the InnerList.  But, I thought I would point out this 
 simple 
 little inconsistency.
+
+------- Additional Comments From lluis@ximian.com  2004-03-29 12:02 -------
+The implementation of ArrayList is correct. The problem is that your
+implementation of the Equals method is wrong.
+The documentation of Object.Equals() says:
+
+Notes to Implementers
+(...)
+The following statements must be true for all implementations of the
+Equals method: 
+(...)
+ * x.Equals(y) returns the same value as y.Equals(x).
+
+Column.Equals does not follow that rule, sine
+col.Equals("TABLE.FIELD") != "TABLE.FIELD".Equals(col).
+