[Mono-bugs] [Bug 54917][Wis] Changed - Avoid emitting redundant null checks on callvirt
bugzilla-daemon@bugzilla.ximian.com
bugzilla-daemon@bugzilla.ximian.com
Sun, 29 Feb 2004 22:54:38 -0500 (EST)
Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.
Changed by bmaurer@users.sf.net.
http://bugzilla.ximian.com/show_bug.cgi?id=54917
--- shadow/54917 2004-02-29 20:12:17.000000000 -0500
+++ shadow/54917.tmp.7443 2004-02-29 22:54:38.000000000 -0500
@@ -1,23 +1,23 @@
Bug#: 54917
-Product: Mono/Compilers
+Product: Mono/Runtime
Version: unspecified
OS: unknown
OS Details:
Status: REOPENED
Resolution:
Severity: Unknown
Priority: Wishlist
-Component: C#
+Component: misc
AssignedTo: mono-bugs@ximian.com
ReportedBy: bmaurer@users.sf.net
QAContact: mono-bugs@ximian.com
TargetMilestone: ---
URL:
Cc:
-Summary: We miss some optimizations with callvirt
+Summary: Avoid emitting redundant null checks on callvirt
Callvirt not only does vtable lookups, but also does checking for null
values. It is what generates NullReferenceExceptions. However, the checks
obviously come at a cost. Right now, we do not avoid callvirt in some
situations when we can.
@@ -116,6 +116,9 @@
to get a good portion of that improvement without regressions. Even a
1% global increase would be *very* cool.
------- Additional Comments From lupus@ximian.com 2004-02-29 20:12 -------
Those kind of more complicated cases should be left to the jit to
optimize.
+
+------- Additional Comments From bmaurer@users.sf.net 2004-02-29 22:54 -------
+Good point, this is probably better for the JIT.