[Mono-bugs] [Bug 56774][Nor] Changed - int -> byte better conversion than int -> short

[bugzilla-daemon@bugzilla.ximian.com]

Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

Changed by rharinath@novell.com.

http://bugzilla.ximian.com/show_bug.cgi?id=56774

--- shadow/56774	2004-06-24 10:33:30.000000000 -0400
+++ shadow/56774.tmp.27472	2004-06-24 10:52:28.000000000 -0400
@@ -108,6 +108,19 @@
 
 
 ------- Additional Comments From rharinath@novell.com  2004-06-24 10:33 -------
 Created an attachment (id=8329)
 proposed fix
 
+
+------- Additional Comments From rharinath@novell.com  2004-06-24 10:52 -------
+The "implicit integral constant conversion" section is wrong in this
+function.  At this point we know that there's an implicit conversion
+from 'a' to 'p' and from 'a' to 'q'.  The implicit integral constant
+conversion check is already performed in
+Convert.ImplicitConversionExists().  If this was an optimization, then
+it is quite wrong, it tries to munge section 6.1.6 and 7.4.2.3.
+
+The BetterConversion function is mainly meant to compare 'p' and 'q'
+only -- and now follows 7.4.2.3 almost exactly (except for the two
+NULL special cases at the top).
+