[Mono-bugs] [Bug 60056][Cri] Changed - [PATCH] BIGMUL does not handle signs correctly

bugzilla-daemon@bugzilla.ximian.com bugzilla-daemon@bugzilla.ximian.com
Sat, 12 Jun 2004 00:27:47 -0400 (EDT)


Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

Changed by bmaurer@users.sf.net.

http://bugzilla.ximian.com/show_bug.cgi?id=60056

--- shadow/60056	2004-06-12 00:26:00.000000000 -0400
+++ shadow/60056.tmp.7962	2004-06-12 00:27:47.000000000 -0400
@@ -10,14 +10,13 @@
 Component: misc
 AssignedTo: mono-bugs@ximian.com                            
 ReportedBy: sebastien@ximian.com               
 QAContact: mono-bugs@ximian.com
 TargetMilestone: ---
 URL: 
-Cc: 
-Summary: BIGMUL does not handle signs correctly
+Summary: [PATCH] BIGMUL does not handle signs correctly
 
 Description of Problem:
 Multiplying a long with a negative integer results in a big positive
 integer. There are no (visible) overflow involved.
 
 
@@ -115,6 +114,11 @@
   26:	f7 e1                	mul    ecx
 
 ------- Additional Comments From bmaurer@users.sf.net  2004-06-12 00:25 -------
 Created an attachment (id=8140)
 Patch
 
+
+------- Additional Comments From bmaurer@users.sf.net  2004-06-12 00:27 -------
+This patch makes the BIGMUL code require that the two operands of the
+multiply use the same conversion op. E.g, ((ulong) x) * ((long) y)
+will need to use the long path.