[Mono-bugs] [Bug 60933][Wis] Changed - [PATCH] Remove literals from static data
Tue, 6 Jul 2004 07:15:03 -0400 (EDT)
Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.
Changed by firstname.lastname@example.org.
--- shadow/60933 2004-07-05 14:38:10.000000000 -0400
+++ shadow/60933.tmp.9932 2004-07-06 07:15:03.000000000 -0400
@@ -74,6 +74,21 @@
------- Additional Comments From email@example.com 2004-07-05 14:38 -------
NB: My justification for combinding the RVA and constant data into one
pointer is that the spec says a variable can declare "optionally
either a <fieldInit> form or a data label". So, they are mutually
+------- Additional Comments From firstname.lastname@example.org 2004-07-06 07:15 -------
+Make the test return a non-zero value from Main if it fails.
+It's also a good rule to use different values when testing multiple
+cases like that: don't use the value '1' all the time.
+In cases like this, the test should check the boundary conditions,
+like: are signed and unsigned values handled correctly? The test
+doesn't show, so it doesn't inspire much confidence.
+That said, once you write a proper test case, commit it in mono/tests
+and commit the patch.
+And since you're working in this area: the spec says that the type of
+the constant may not match the type of the field. This means that the
+code was and remains incorrect: please write the test case in IL and
+change the code to handle this case.