[Mono-bugs] [Bug 52754][Wis] Changed - BinaryWriter allocates too many char [] buffers for encoding

bugzilla-daemon@bugzilla.ximian.com bugzilla-daemon@bugzilla.ximian.com
Tue, 20 Jan 2004 15:58:54 -0500 (EST)

Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

Changed by bmaurer@users.sf.net.


--- shadow/52754	2004-01-11 16:06:54.000000000 -0500
+++ shadow/52754.tmp.24603	2004-01-20 15:58:54.000000000 -0500
@@ -1,14 +1,14 @@
 Bug#: 52754
 Product: Mono/Class Libraries
 Version: unspecified
+OS: unknown
 OS Details: 
 Status: NEW   
+Severity: Unknown
 Priority: Wishlist
 Component: CORLIB
 AssignedTo: mono-bugs@ximian.com                            
 ReportedBy: bmaurer@users.sf.net               
 QAContact: mono-bugs@ximian.com
 TargetMilestone: ---
@@ -25,6 +25,13 @@
   Callers (with count) that contribute at least for 1%:
        12884  100 % System.IO.BinaryReader::ReadString()
 What we should do is to allocate one buffer of a specific number of chars,
 and then always use this buffer. That way, we save the cost of allocating
 each time. You can see this by doing ReadString in a tight loop.
+------- Additional Comments From bmaurer@users.sf.net  2004-01-20 15:58 -------
+This will fix it and do a couple of other byte optimizations.
+ReadDecimal fails, but i think it also failed before.