[Mono-bugs] [Bug 53026][Wis] New - We should not be locking in FileStream

bugzilla-daemon@bugzilla.ximian.com bugzilla-daemon@bugzilla.ximian.com
Sun, 18 Jan 2004 11:28:53 -0500 (EST)

Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

Changed by bmaurer@users.sf.net.


--- shadow/53026	2004-01-18 11:28:53.000000000 -0500
+++ shadow/53026.tmp.31966	2004-01-18 11:28:53.000000000 -0500
@@ -0,0 +1,36 @@
+Bug#: 53026
+Product: Mono/Class Libraries
+Version: unspecified
+OS Details: 
+Status: NEW   
+Priority: Wishlist
+Component: CORLIB
+AssignedTo: mono-bugs@ximian.com                            
+ReportedBy: bmaurer@users.sf.net               
+QAContact: mono-bugs@ximian.com
+TargetMilestone: ---
+Summary: We should not be locking in FileStream
+In FileStream, we are doing
+lock (this) {
+   // read, write, etc
+According to Miguel, this was in order to work around bug 32344.
+However, Miguel also said:
+<miguel> ok, the locks were added because of a bug
+<miguel> Now, the good news is that
+<miguel> After reading that bug report, am sure that I had fixed that later
+<miguel> By making all the methods in Console Synchronized
+<miguel> So the bug must be fixed correctly now
+If I remove all the locks from FileStream.cs, compile/install, then run the
+bug 32344 test case, it works as expected.