[Mono-bugs] [Bug 52655][Nor] Changed - Custom attributes should not be cached

bugzilla-daemon@bugzilla.ximian.com bugzilla-daemon@bugzilla.ximian.com
Wed, 7 Jan 2004 17:41:34 -0500 (EST)

Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

Changed by lluis@ximian.com.


--- shadow/52655	2004-01-07 15:38:48.000000000 -0500
+++ shadow/52655.tmp.13225	2004-01-07 17:41:34.000000000 -0500
@@ -52,6 +52,15 @@
 ------- Additional Comments From vargaz@freemail.hu  2004-01-07 15:38 -------
 A better solution would be to somehow copy the attributes returned
 from the API calls, since removing the cache means that IsDefined 
 needs to construct all the attributes for a type on each invocation,
 which is not very perf friendly.
+------- Additional Comments From lluis@ximian.com  2004-01-07 17:41 -------
+Actually, IsDefined shouldn't need to create any attribute instance,
+since it only has to check attribute types. 
+In any case, I don't see how a copy of the attributes could be faster
+than the normal initialization process. It can't be just a flat copy,
+an attribute could have complex internal data structures the would
+also need to be copied.