[Mono-bugs] [Bug 54303][Nor] Changed - generated inverted floating point comparisons are not correct

bugzilla-daemon@bugzilla.ximian.com bugzilla-daemon@bugzilla.ximian.com
Sun, 15 Feb 2004 00:37:35 -0500 (EST)


Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

Changed by bmaurer@users.sf.net.

http://bugzilla.ximian.com/show_bug.cgi?id=54303

--- shadow/54303	2004-02-14 14:33:39.000000000 -0500
+++ shadow/54303.tmp.26430	2004-02-15 00:37:35.000000000 -0500
@@ -10,13 +10,12 @@
 Component: C#
 AssignedTo: mono-bugs@ximian.com                            
 ReportedBy: vargaz@freemail.hu               
 QAContact: mono-bugs@ximian.com
 TargetMilestone: ---
 URL: 
-Cc: 
 Summary: generated inverted floating point comparisons are not correct
 
 Using the following testcase:
 
 		double a = Double.NaN;
 
@@ -45,6 +44,19 @@
 patch
 
 
 ------- Additional Comments From bmaurer@users.sf.net  2004-02-14 14:33 -------
 Ok, we just forgot to copy the code for this case into two other
 statements.
+
+------- Additional Comments From bmaurer@users.sf.net  2004-02-15 00:37 -------
+for the record, regression tests pass with this.
+
+Before I check this in, however, I want to generate a test suite for
+all the compare possibilities. We should just have a program generate
+code like:
+
+double a, b; // vary these
+if (!(a < b ? expected_true : !expected_true))
+    Fail ("a < b");
+
+(the redundant code is ot make sure we use branchable).