[Mono-bugs] [Bug 52754][Wis] Changed - [PATCH] BinaryWriter allocates too many char [] buffers for encoding
bugzilla-daemon@bugzilla.ximian.com
bugzilla-daemon@bugzilla.ximian.com
Thu, 30 Dec 2004 14:16:35 -0500 (EST)
Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.
Changed by bmaurer@users.sf.net.
http://bugzilla.ximian.com/show_bug.cgi?id=52754
--- shadow/52754 2004-05-12 13:19:15.000000000 -0400
+++ shadow/52754.tmp.3915 2004-12-30 14:16:35.000000000 -0500
@@ -12,12 +12,13 @@
ReportedBy: bmaurer@users.sf.net
QAContact: mono-bugs@ximian.com
TargetMilestone: ---
URL:
Cc:
Summary: [PATCH] BinaryWriter allocates too many char [] buffers for encoding
+BugsThisDependsOn: 70471
If you call
bw.ReadString () many times, you will see a profile like:
657 KB System.Text.Encoding::GetChars(byte[],int,int)
@@ -32,6 +33,10 @@
------- Additional Comments From bmaurer@users.sf.net 2004-01-20 15:58 -------
http://devservices.go-mono.com/~benm/patches/io-binary-reader-string-byte-opts.patch
This will fix it and do a couple of other byte optimizations.
ReadDecimal fails, but i think it also failed before.
+
+------- Additional Comments From bmaurer@users.sf.net 2004-12-30 14:16 -------
+Once we get the bug on reading strings in bug 70471 fixed, I will get
+this fully tested and in.