[Mono-bugs] [Bug 70129][Nor] Changed - Private events are not really private

bugzilla-daemon@bugzilla.ximian.com bugzilla-daemon@bugzilla.ximian.com
Thu, 2 Dec 2004 07:35:00 -0500 (EST)

Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

Changed by duncan@ximian.com.


--- shadow/70129	2004-12-02 06:35:46.000000000 -0500
+++ shadow/70129.tmp.5000	2004-12-02 07:35:00.000000000 -0500
@@ -2,13 +2,13 @@
 Product: Mono: Compilers
 Version: 1.1
 OS: SUSE 9.1
 OS Details: 
 Status: NEW   
+Severity: Unknown
 Priority: Normal
 Component: C#
 AssignedTo: mono-bugs@ximian.com                            
 ReportedBy: lluis@ximian.com               
 QAContact: mono-bugs@ximian.com
 TargetMilestone: ---
@@ -38,6 +38,20 @@
 Actual Results:
 Expected Results:
 error CS0122: 'BB.AnEvent' is inaccessible due to its protection level.
+------- Additional Comments From duncan@ximian.com  2004-12-02 07:34 -------
+Went to bed early, but then again, woke up early too. Nothing better
+to do at 6 in the morning....
+Here's a patch that at least makes the compiler report the right warning.
+Basically, EventExpr.DoResolve is not doing any checks on visibility.
+Taking PropertyExpr.DoResolve as an example, I copied
+PropertyExpr.IsAccessorAccessible into EventExpr and made it check the
+visibility of the add_accessor.
+There's this field "must_do_cs1540_check", but I don't think that
+relates to events, so I just removed it.