[Mono-bugs] [Bug 63165][Nor] New - [PATCH] Support for undocumented connection string keywords, improved value checks

[bugzilla-daemon@bugzilla.ximian.com]

Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

Changed by gert.driesen@pandora.be.

http://bugzilla.ximian.com/show_bug.cgi?id=63165

--- shadow/63165	2004-08-16 13:40:53.000000000 -0400
+++ shadow/63165.tmp.20935	2004-08-16 13:40:53.000000000 -0400
@@ -0,0 +1,37 @@
+Bug#: 63165
+Product: Mono: Class Libraries
+Version: unspecified
+OS: All
+OS Details: Gentoo 2.6.7 R13 and Windows XP SP2
+Status: NEW   
+Resolution: 
+Severity: 
+Priority: Normal
+Component: Sys.Data.SqlClient
+AssignedTo: rodrigo@novell.com                            
+ReportedBy: gert.driesen@pandora.be               
+QAContact: mono-bugs@ximian.com
+TargetMilestone: ---
+URL: 
+Cc: 
+Summary: [PATCH] Support for undocumented connection string keywords, improved value checks
+
+I've attached a patch for SqlConnection that 
+
+- adds TODO on ConnectionString for keywords that are not yet implemented
+- checks value of Integrated Security keyword
+- checks value of bool keywords
+- improves error reporting for int keywords
+- added supports for the following undocumented keyword synonyms : APP, 
+TIMEOUT, NETWORK, PERSISTSECURITYINFO, WSID, LANGUAGE, USER
+- throws NotImplementedException when encrypt keyword is set to true, 
+enlist keyword is set to false or attachdbfilename keyword (or one of its 
+synonyms) is set as none of these are implemented
+- Added FIXME for PERSIST SECURITY INFO keyword as its not implemented, 
+throwing a NotImplementedException here would break lots of apps
+
+I attached a patch for SqlConnection.cs (including ChangeLog entry), and 
+unit tests (two tests currently fail on Mono, due to other issues)
+
+Can someone review the patch and commit these changes or let me know 
+whether its ok to commit them ?