[Mono-bugs] [Bug 62613][Wis] New - [Patch] Mono.Data.SqliteClient named input parameters

bugzilla-daemon@bugzilla.ximian.com bugzilla-daemon@bugzilla.ximian.com
Fri, 6 Aug 2004 03:52:58 -0400 (EDT)

Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

Changed by chris@turchin.net.


--- shadow/62613	2004-08-06 03:52:58.000000000 -0400
+++ shadow/62613.tmp.23545	2004-08-06 03:52:58.000000000 -0400
@@ -0,0 +1,69 @@
+Bug#: 62613
+Product: Mono: Class Libraries
+Version: unspecified
+OS: unknown
+OS Details: 
+Status: NEW   
+Priority: Wishlist
+Component: Sys.Data
+AssignedTo: mono-bugs@ximian.com                            
+ReportedBy: chris@turchin.net               
+QAContact: mono-bugs@ximian.com
+TargetMilestone: ---
+Summary: [Patch] Mono.Data.SqliteClient named input parameters
+I know this is not a System.Data thing, but Mono.Data is not in the
+components list...
+this is a patch i had written a while back for Mono.Data.Sqlite to add
+named input parameters - see below for more details.
+> Date: Mon, 24 May 2004 15:58:14 -0700
+> From: Vladimir Vukicevic <vladimir@pobox.com>
+> To: Chris Turchin <chris@turchin.net>
+> Subject: Re: [Patch] Mono.Data.SqliteClient named input parameters
+> Hi Chris,
+> Chris Turchin wrote:
+> > I wrote a patch a while back for Mono.Data.Sqlite to add named
+> > parameters among some other things (see below and in the diff for more
+> > details). Since you are the original author of the Sqlite provider (and
+> > since nobody else replied to my email to the list) I was hoping I could
+> > ask you to review it and give me feedback if it is okay to commit.
+> >
+> > If you have a chance to look it over and give me some feedback I would
+> > be most grateful.
+> Thanks for the patch!  This is something I wanted to do a while back,
+> but never got around to it.  The patch looks fine, please go ahead and
+> commit -- I just noticed that the file is using the very old
+> (spaces-only, 8-space offsets) indenting style, I'll probably go in and
+> retabify everything after your commit to make it conform.  It would
+> probably be best for your patch to go in as-is (without munging the
+> other indenting), so that it's clear what was changed.
+> Incidentally, you should probably subscribe to mono-devel-list and send
+> future patches there (not mono-list); you'll probably get a much better
+> response there. :)
+>         - Vlad
+I have had to redo the patch once already, since things in cvs had changed
+since i subimitted it intially. since i do not have cvs commit, i had
+posted it to the mono-devel-list (and incorrectly to the mono-list, sorry!)
+and also sent it to several people to have it committed. but it has fallen
+through the cracks i guess... perhaps it will get applied if i post it to
+if there is something wrong with it and it is not being commited because it
+is not good code, it has bad style, or whatever, pls tell me and i will try
+and improve it.