[Mono-bugs] [Bug 60997][Wis] Changed - [PATCH] CS0626 is reported when the DllImport attribute is not found

[bugzilla-daemon@bugzilla.ximian.com]

Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

Changed by miguel@ximian.com.

http://bugzilla.ximian.com/show_bug.cgi?id=60997

--- shadow/60997	2004-08-03 04:24:40.000000000 -0400
+++ shadow/60997.tmp.28347	2004-08-04 13:53:38.000000000 -0400
@@ -1,15 +1,15 @@
 Bug#: 60997
 Product: Mono: Compilers
 Version: unspecified
 OS: unknown
 OS Details: 
-Status: RESOLVED   
-Resolution: FIXED
+Status: REOPENED   
+Resolution: 
 Severity: Unknown
-Priority: Minor
+Priority: Wishlist
 Component: C#
 AssignedTo: rharinath@novell.com                            
 ReportedBy: vargaz@freemail.hu               
 QAContact: mono-bugs@ximian.com
 TargetMilestone: ---
 URL: 
@@ -85,6 +85,35 @@
 
 ------- Additional Comments From rharinath@novell.com  2004-08-03 04:24 -------
 Applied to CVS
 
 (r=martin)
 
+
+------- Additional Comments From miguel@ximian.com  2004-08-04 13:53 -------
+This patch is wrong, it now produces errors when compiling Blam for
+valid code.
+
+Download blam-1.2.1.tar.gz to see the problem;  Sadly, there is no
+simple test case for it, the error reported is:
+
+Channel.cs(18) error CS0246: Could not find attribute 'XmlAttribute'
+(are you missing a using directive or an assembly reference ?)
+Channel.cs(18) error CS8006: Attribute XmlAttribute resolved to
+different types at different times:  vs.
+System.Xml.Serialization.XmlAttributeAttribute
+
+Notice that it has an empty string for the above.
+
+Also the patch does not follow the coding conventions:
+
+    ! complained_before
+
+Should be:
+
+    !complained_before
+
+I have reverted this.
+
+Notice that this is really a wishlist bug, and there are others
+that we should probably focus on (Major, Critical, Normal)
+