[Mono-bugs] [Bug 55909][Wis] Changed - Deadlock in ReaderWriterLock.UpgradeToWriterLock()

bugzilla-daemon@bugzilla.ximian.com bugzilla-daemon@bugzilla.ximian.com
Tue, 13 Apr 2004 07:37:59 -0400 (EDT)

Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

Changed by lluis@ximian.com.


--- shadow/55909	2004-04-12 11:22:06.000000000 -0400
+++ shadow/55909.tmp.28096	2004-04-13 07:37:59.000000000 -0400
@@ -313,6 +313,25 @@
 ------- Additional Comments From mono-bug@jerryweb.info  2004-04-12 11:22 -------
 Created an attachment (id=7318)
 Patch - see attachment
+------- Additional Comments From lluis@ximian.com  2004-04-13 07:37 -------
+Hi Jan, thanks for the tests cases, you are really good at finding
+deadlocks. I commited fixes for all this and some unit tests for them.
+I really appreciate your interest in improving the ReadWriterLock
+class, however, in general it is a better approach to fix bugs on an
+existing implementation rather than rewriting it, as far as the
+existing implementation is based in a correct design and do not have
+major flaws. This is the best way to get reliable code. The
+probability to introduce new bugs in a rewrite is way higher than when
+focusing on fixing bugs. As an example, when I first rewrote the class
+(and that time it was really necessary) XSP stoped working. Your
+implementation fixes your bugs, but are you sure that it does not
+break anything else that works with the current implementation? At
+least, two unit tests are failing with your class.
+In any case, thanks for your interest. Please, keep reporting.