[Mono-bugs] [Bug 56454][Maj] Changed - [PATCH] Array assignment of concatentated strings leads to duplication

bugzilla-daemon@bugzilla.ximian.com bugzilla-daemon@bugzilla.ximian.com
Sat, 10 Apr 2004 15:09:48 -0400 (EDT)

Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

Changed by miguel@ximian.com.


--- shadow/56454	2004-04-10 13:45:45.000000000 -0400
+++ shadow/56454.tmp.28509	2004-04-10 15:09:48.000000000 -0400
@@ -97,6 +97,18 @@
 That appears to solve the problem, does someone want to commit it?
 ------- Additional Comments From bmaurer@users.sf.net  2004-04-10 13:45 -------
 it is pending approval from miguel
 /me looks at miggy
+------- Additional Comments From miguel@ximian.com  2004-04-10 15:09 -------
+We should avoid using a new boolean to track this state.
+One of the invariants of expressions is that they are born in 
+unresolved state, and "eclass" and "type" are non-valid.
+After resolution, eclass has a valid ExprClass value (other than
+Invalid) and type has the System.Type for the type of the expression.
+So you could test for `type != null' for the fact that the expression
+has previously been resolved