[Mono-bugs] [Bug 49580][Min] Changed - GetNamespaceOfPrefix

bugzilla-daemon@bugzilla.ximian.com bugzilla-daemon@bugzilla.ximian.com
Sun, 12 Oct 2003 19:42:39 -0400 (EDT)

Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

Changed by mass@akuma.org.


--- shadow/49580	2003-10-12 18:53:46.000000000 -0400
+++ shadow/49580.tmp.31058	2003-10-12 19:42:39.000000000 -0400
@@ -35,6 +35,16 @@
 I would assume that this impl is a hold over with some quick work 
 done that needs to be cleaned up, and re-implemented a bit. If you 
 would like a test case of something that works fine on ms.net and 
 doesnt work on mono regarding the use of this function, ask, and I 
 will whip on together.
+------- Additional Comments From mass@akuma.org  2003-10-12 19:42 -------
+two recommended changes:
+compare the Node against null rather than checking its type against 
+DocumentType. this will let it work against detached nodes.
+first check the current element prefix against the prefix you are 
+comparing. This will optimize the case even if the prefix is 
+declared as an xmlns:* attribute, and greatly improve the case where 
+it isn't.