[Mono-bugs] [Bug 44830][Nor] Changed - Wrong behaviour of Regex.Split()

bugzilla-daemon@rocky.ximian.com bugzilla-daemon@rocky.ximian.com
Tue, 17 Jun 2003 17:07:43 -0400 (EDT)


Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

Changed by duncan@ximian.com.

http://bugzilla.ximian.com/show_bug.cgi?id=44830

--- shadow/44830	Tue Jun 17 16:55:03 2003
+++ shadow/44830.tmp.24807	Tue Jun 17 17:07:43 2003
@@ -73,6 +73,17 @@
 
 
 ------- Additional Comments From primey@gmx.net  2003-06-17 16:55 -------
 The patch works fine.
 Please commit it.
 
+
+------- Additional Comments From duncan@ximian.com  2003-06-17 17:07 -------
+Wait.....
+
+Let's see if we can get some more review first before committing code
+to the repository.
+
+The patch has a style issue, please keep braces on the same line as
+the conditional. In fact, for one line, the brace is not necessary.
+
+Do we have any test suites on Regex? If not, let's start building one.