[Mono-bugs] [Bug 40315][Maj] Changed - SqlCommand::ExecuteNonQuery always returns 0

bugzilla-daemon@bugzilla.ximian.com bugzilla-daemon@bugzilla.ximian.com
Mon, 18 Aug 2003 09:39:49 -0400 (EDT)


Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

Changed by joergr@voelcker.com.

http://bugzilla.ximian.com/show_bug.cgi?id=40315

--- shadow/40315	2003-08-18 09:39:10.000000000 -0400
+++ shadow/40315.tmp.30499	2003-08-18 09:39:49.000000000 -0400
@@ -2,13 +2,13 @@
 Product: Mono/Class Libraries
 Version: unspecified
 OS: Debian Woody
 OS Details: 
 Status: NEW   
 Resolution: 
-Severity: 
+Severity: Unknown
 Priority: Major
 Component: System.Data.SqlClient
 AssignedTo: rodrigo@ximian.com                            
 ReportedBy: JoergR@voelcker.com               
 QAContact: mono-bugs@ximian.com
 TargetMilestone: ---
@@ -44,6 +44,15 @@
 
 
 ------- Additional Comments From JoergR@voelcker.com  2003-08-18 09:39 -------
 Created an attachment (id=5153)
 Patch for System.Data.SqlClient
 
+
+------- Additional Comments From JoergR@voelcker.com  2003-08-18 09:39 -------
+1) I have changed ExecuteNonQuery to return Connection.Tds.RecordsAffected
+if it is successfull. 
+
+2) RecordsAffected was not filled correctly by Tds.ProcessEndToken. 
+I've found out that the record count was submitted for 
+TdsPacketSubType.Done. So I changed the behaviour to include this
+(without deeper knowledge of the TDS protocol).