[Mono-bugs] [Bug 47460][Nor] New - Multiple bugs in System.Collections.DictionaryBase

[bugzilla-daemon@indri.ximian.com]

Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

Changed by barce@frlp.utn.edu.ar.

http://bugzilla.ximian.com/show_bug.cgi?id=47460

--- shadow/47460	2003-08-10 22:45:19.000000000 -0400
+++ shadow/47460.tmp.22928	2003-08-10 22:45:20.000000000 -0400
@@ -0,0 +1,40 @@
+Bug#: 47460
+Product: Mono/Class Libraries
+Version: unspecified
+OS: All
+OS Details: 
+Status: NEW   
+Resolution: 
+Severity: 
+Priority: Normal
+Component: CORLIB
+AssignedTo: mono-bugs@ximian.com                            
+ReportedBy: barce@frlp.utn.edu.ar               
+QAContact: mono-bugs@ximian.com
+TargetMilestone: ---
+URL: 
+Cc: 
+Summary: Multiple bugs in System.Collections.DictionaryBase
+
+I found several bugs in DictionaryBase, I wrote a patch to fix them, I'm
+attaching a patch and a new DictionaryBaseTest NUNit Fixture with 30 tests
+on DictionaryBase. These tests were developed and tested with MS .NET
+Framework and NUNit under Windows.
+
+- Idictionary.Add 
+	added OnValidate 
+	undo the transaction if OnInsertCompleteFails.
+
+- Indexer SET
+	MS Implementation does not call OnInsert and undoes if OnSetComplete
+throws an exception
+
+- Indexer GET
+	return value is obtained after calling OnGet.
+
+- IDictionary.Remove
+	Call to OnValidate added. If key does not exists calls OnValidate,
+OnRemove and OnRemoveComplete.
+
+- protected IDictionary Dictionary GET
+	Should return itself, not the inner hashtable.