[Mono-bugs] [Bug 30781][Min] Changed - File names must be converted to utf8 before g_utf8_to_utf16

bugzilla-daemon@rocky.ximian.com bugzilla-daemon@rocky.ximian.com
22 Sep 2002 17:23:00 -0000


Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

Changed by gonzalo@ximian.com.

http://bugzilla.ximian.com/show_bug.cgi?id=30781

--- shadow/30781	Fri Sep 20 09:20:24 2002
+++ shadow/30781.tmp.7011	Sun Sep 22 13:23:00 2002
@@ -2,13 +2,13 @@
 Product: Mono/Runtime
 Version: unspecified
 OS: other
 OS Details: 
 Status: NEW   
 Resolution: 
-Severity: 
+Severity: Unknown
 Priority: Minor
 Component: misc
 AssignedTo: mono-bugs@ximian.com                            
 ReportedBy: gonzalo@ximian.com               
 QAContact: mono-bugs@ximian.com
 TargetMilestone: ---
@@ -22,7 +22,25 @@
 it does not seem to work. Let's see what happens with
 http://bugzilla.gnome.org/show_bug.cgi?id=93751
 
 ------- Additional Comments From gonzalo@ximian.com  2002-09-20 09:20 -------
 Created an attachment (id=2319)
 Uses g_filename_to_utf8 in FindNextFile
+
+
+------- Additional Comments From gonzalo@ximian.com  2002-09-22 13:22 -------
+Take a look at the comments on the pretended bug in glib.
+
+It's up to the user to set G_BROKEN_FILENAMES if he uses non-ASCII and
+non-UTF8 encoding for his files.
+
+We should call setlocale (LC_ALL, "") and use g_filename_to_utf8 ()
+before g_path_get_basename ().
+
+(optional) We could also give a warning telling the user what to do
+(ie, set the envvar and/or a proper LC_ALL)
+
+It will also be nicer if we just ignore files giving errors instead of
+crashing.
+
+