[Mono-bugs] [Bug 23541][Wis] Changed - mcs needs to deal with the encoding of source files

bugzilla-daemon@rocky.ximian.com bugzilla-daemon@rocky.ximian.com
28 Aug 2002 00:29:44 -0000

Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

Changed by martin@gnome.org.


--- shadow/23541	Tue Aug 27 13:24:21 2002
+++ shadow/23541.tmp.13234	Tue Aug 27 20:29:44 2002
@@ -3,13 +3,13 @@
 Version: unspecified
 OS: unknown
 OS Details: 
 Status: NEW   
 Severity: Unknown
-Priority: Normal
+Priority: Wishlist
 Component: Misc
 AssignedTo: mono-bugs@ximian.com                            
 ReportedBy: martin@cwanet.com               
 QAContact: mono-bugs@ximian.com
 TargetMilestone: ---
@@ -99,6 +99,23 @@
 Moving to mcs: mcs needs to validate the source files for the correct
 encoding (maybe starting with utf8 and then falling back to latin1 or
 the default encoding for the locale...).
 ------- Additional Comments From lupus@ximian.com  2002-08-27 13:24 -------
 *** Bug 27655 has been marked as a duplicate of this bug. ***
+------- Additional Comments From martin@gnome.org  2002-08-27 20:29 -------
+Hmm, how should MCS do this, it's using a StreamReader() to read the file ?
+At the moment, there's nothing I can do against this in MCS:
+* the runtime doesn't report any exception, it just blindly ignores the characters so MCS won't even see that something's wrong.
+* according to the documentation it's the runtime's job to autodetect the encoding of a file
+  See ms-help://MS.NETFrameworkSDK/cpref/html/frlrfsystemiostreamreaderclasscurrentencodingtopic.htm,
+  t says that StreamReader.CurrentEncoding is set after the first Read() since the encoding is autodetected.
+So IMHO this must be done either by the runtime or by our StreamReader implementation.
+I don't want to "force" this bug back into the runtime, so keeping it here and setting priority to wishlist.