[Gtk-sharp-list] Can we make NodeStore.GetPath public?

Ben Maurer bmaurer at ximian.com
Sat Sep 17 17:23:36 EDT 2005

On Sat, 2005-09-17 at 13:55 -0700, Eric Butler wrote:
> Okay, thats fair enough, can I commit this then?
> +               public bool GetRowExpanded (ITreeNode node)
> +               {
> +                       Gtk.TreePath path = store.GetPath (node);
> +                       return base.GetRowExpanded (path);
> +               }
>         }
>  }

The swing tree calls this method "IsExpanded". I think that makes more
sense. "Row" is not part of the vocabulary for the this tree, so if you
want a noun in there, it should really be "Node".

Also, "Get" is not really the best verb here, try reading these two
fragments out loud:

if (my_view.IsExpanded (node))
	Console.WriteLine ("X");

if (my_view.GetRowExpanded (node))
	Console.WriteLine ("Y");

Also, it would help to at least deal with ExpandRow at the same time we
do this. Ideally we could deal with all the instances of TreePath:

[benm at omega ~]$ monop nodeview  | grep TreePath | wc -l

And, of course, docs!


-- Ben

More information about the Gtk-sharp-list mailing list