[Gtk-sharp-list] [PATCH] Remove need for ColumnCount and allow fields in NodeStore

Ben Maurer bmaurer at ximian.com
Wed Aug 17 19:22:06 EDT 2005


Hey guys,

This is a patch to make NodeStore a bit easier to use. I did three things:

1) I changed the way types are scanned so that the Column = blah was not
needed in TreeNodeAttribute. This makes all tree-style uses of TreeNode
not require the attribute at all.

2) Fields can now be used at values in the tree node

Also, I did a minor public api fixup. This technically breaks the freeze.
However, I do not believe that it would affect any users.

In bug http://bugzilla.ximian.com/show_bug.cgi?id=69288, Duncan added
AllowMultiple=true to TreeNodeValueAttribute. He also added fields to this
that would allow it to be autoconnected to a specific type of renderer.
Thus, it made sense that maybe one would want a specifc column to appear
more than once. However, Mike decided not to go ahead with this part of
the patch. When revising the patch, the AllowMultiple=true was kept in by
mistake. The AllowMultiple may raise questions as to what it would be used
for. IMHO, removing it makes the api simpler. I think the chances of this
breaking a user's app are extremely small. However, I can easily change my
patch to cope with the akward usage if we want to be extra-strict about
compat.

-- Ben

-------------- next part --------------
A non-text attachment was scrubbed...
Name: nodestore-fields-fewer-attr.patch
Type: text/x-patch
Size: 4401 bytes
Desc: not available
Url : http://lists.ximian.com/pipermail/gtk-sharp-list/attachments/20050817/a3774890/nodestore-fields-fewer-attr.bin


More information about the Gtk-sharp-list mailing list