[Gtk-sharp-list] patch for gnome binding

Mike Kestner mkestner@ximian.com
Mon, 12 Jul 2004 11:34:58 -0500

On Mon, 2004-07-12 at 10:55, Martin Willemoes Hansen wrote:

> > I'm not convinced it's a good idea to expose set_Config publicly. I
> > would just invoke the glue method from the ctor instead and leave the
> > property read only.
> Ok, here is yet another updated patch ;) 

Why did you switch to using g_object_set?  Are you certain that will
take a ref and assign the config field of the GnomePrintJob struct for
the job?  It seems really inefficient at best to do it that way.  Why
not just:

job->config = gnome_print_config_ref (config);

Also, your .custom should import and use
gnomesharp_print_job_set_print_config, since that's what you named the
method in the glue.

Mike Kestner <mkestner@ximian.com>