[Gtk-sharp-list] patch for gnome binding
Mon, 12 Jul 2004 09:48:08 -0500
On Mon, 2004-07-12 at 09:37, Mike Kestner wrote:
> On Mon, 2004-07-12 at 08:43, Martin Willemoes Hansen wrote:
> > Okay, here is a quick try to implement the suggestions you mentioned,
> > what do you think?
> You didn't add the glue file to the Makefile.am, so it's not getting
> built. If it had been compiled, you would've seen that the glue isn't
> right. ;-)
> Your set_print_config method needs to take two parameters, a PrintJob
> and a PrintConfig, and it should set job->config, and from looking at a
> little C code, it should probably take a ref on the config.
> In your Config property in the .custom, you don't need to do the
> IntPtr.Zero check, because GetObject (IntPtr.Zero) returns null.
I'm not convinced it's a good idea to expose set_Config publicly. I
would just invoke the glue method from the ctor instead and leave the
property read only.
Mike Kestner <firstname.lastname@example.org>